Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.virtualenv: add pip test dependency #247313

Closed
wants to merge 1 commit into from
Closed

python3.pkgs.virtualenv: add pip test dependency #247313

wants to merge 1 commit into from

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

This is needed but hidden by the fact that right now the Python setup hooks add pip to the environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 12, 2023

I did not encounter the need for this change while using build/installer.

@tjni
Copy link
Contributor Author

tjni commented Aug 12, 2023

You're right, I don't know what was breaking when I tested earlier, but it passes for me now too without this. Thank you for double checking.

@tjni tjni closed this Aug 12, 2023
@tjni tjni deleted the virtualenv branch August 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants